[igt-dev] [PATCH i-g-t 2/2] runner: Introduce --disk-usage-limit

Arkadiusz Hiler arkadiusz.hiler at intel.com
Thu Jun 18 12:26:28 UTC 2020


On Thu, Jun 18, 2020 at 03:06:23PM +0300, Petri Latvala wrote:
> Disk usage limit is a limit of disk space taken, per (dynamic)
> subtest. If the test's output, kernel log included, exceeds this
> limit, the test is killed, similarly to killing the test when the
> kernel gets tainted.

So this is a combined limit, i.e. shared by stderr, stdout and dmesg,
right?

Also since this is handled by need_to_timeout, will the final test
result be a timeout?

Any particular reason why we are killing the test instead of just
appending a message that output was truncated and letting the test be?

When we were talking about this I had imagined something more like:

 1. size limit per logged file
 2. test finishes execution
 3. the logs state that the test was spammy and we truncated the logs
 4. "promote" passes to warns in such cases

No strong feeling on which option we will go with, but I would like to
understand why you went in that way.

-- 
Cheers,
Arek


More information about the igt-dev mailing list