[igt-dev] [PATCH] [PATCH i-g-t] i915/gem_reg_read: Added description for test case

Melkaveri, Arjun arjun.melkaveri at intel.com
Tue Jun 30 06:03:24 UTC 2020


-----Original Message-----
From: Dandamudi, Priyanka <priyanka.dandamudi at intel.com> 
Sent: Monday, June 29, 2020 6:30 PM
To: Melkaveri, Arjun <arjun.melkaveri at intel.com>; igt-dev at lists.freedesktop.org; Dandamudi, Priyanka <priyanka.dandamudi at intel.com>
Subject: [PATCH] [PATCH i-g-t] i915/gem_reg_read: Added description for test case

From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>

Added test description for test and to all 3 subtests.

Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
---
 tests/i915/gem_reg_read.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/i915/gem_reg_read.c b/tests/i915/gem_reg_read.c index 79facc1f..dfc2560e 100644
--- a/tests/i915/gem_reg_read.c
+++ b/tests/i915/gem_reg_read.c
@@ -32,6 +32,7 @@
 #include <sys/utsname.h>
 #include <time.h>
 
+IGT_TEST_DESCRIPTION("Test the basic register read ioctl.");
 
AMK:-  Can you add more information about type of registers this test would check in description.
 
 static bool is_x86_64;
 static bool has_proper_timestamp;
@@ -156,14 +157,19 @@ igt_main
 		has_proper_timestamp = check_timestamp(fd);
 	}
 
+	igt_describe("Verifies reading bad register result in error or not.");
 	igt_subtest("bad-register")
 		igt_assert_eq(read_register(fd, 0x12345678, &val), -EINVAL);
 
+	igt_describe("Checks whether the timestamp register is getting"
+		     " updated when any operation(noop) is being performed.");
 	igt_subtest("timestamp-moving") {
 		igt_skip_on(timer_query(fd, &val) != 0);
 		test_timestamp_moving(fd);
 	}
 
+	igt_describe("Checks whether timestamp is monotonic while performing"
+		     " an operation(noop) in a loop.");
 	igt_subtest("timestamp-monotonic") {
 		igt_skip_on(timer_query(fd, &val) != 0);
 		test_timestamp_monotonic(fd);
--
2.26.2



More information about the igt-dev mailing list