[igt-dev] [PATCH i-g-t] i915/gem_exec_parallel: Try to trim runtime

[Chris Wilson]

Quoting Mika Kuoppala (2020-03-03 14:33:04)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > In all likelihood the runtime is consumed by the thread setup, but just
> > in case it is dominated by the execbuf, make sure that is bounded.
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > ---
> >  tests/i915/gem_exec_parallel.c | 28 ++++++++++++++++------------
> >  1 file changed, 16 insertions(+), 12 deletions(-)
> >
> > diff --git a/tests/i915/gem_exec_parallel.c b/tests/i915/gem_exec_parallel.c
> > index 0d4d6c628..586f85080 100644
> > --- a/tests/i915/gem_exec_parallel.c
> > +++ b/tests/i915/gem_exec_parallel.c
> > @@ -42,22 +42,26 @@
> >  
> >  #define VERIFY 0
> >  
> > +static inline uint32_t hash32(uint32_t val)
> > +{
> > +#define GOLDEN_RATIO_32 0x61C88647
> > +     return val * GOLDEN_RATIO_32;
> > +}
> > +
> >  static void check_bo(int fd, uint32_t handle, int pass)
> >  {
> > -     uint32_t *map;
> > -     int i;
> > +     uint32_t x = hash32(handle * pass) % 1024;
> >  
> >       igt_debug("Verifying result (pass=%d, handle=%d)\n", pass, handle);
> > -     map = gem_mmap__cpu(fd, handle, 0, 4096, PROT_READ);
> > -     gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, 0);
> > -     for (i = 0; i < 1024; i++)
> > -             igt_assert_eq(map[i], i);
> > -     munmap(map, 4096);
> > +     gem_read(fd, handle, x * sizeof(x), &x, sizeof(x));
> > +     igt_assert_eq_u32(x, x);
> 
> This caught my eye.

Fine, I'll read it into a second var.

I thought it looked odd :)
-Chris