[igt-dev] [PATCH i-g-t v2] tests/kms_dp_tiled_display: Increase the time limit to receive all page flips

[Shankar, Uma]

> -----Original Message-----
> From: B S, Karthik <karthik.b.s at intel.com>
> Sent: Friday, March 6, 2020 2:16 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Navare, Manasi D <manasi.d.navare at intel.com>; Shankar, Uma
> <uma.shankar at intel.com>; B S, Karthik <karthik.b.s at intel.com>
> Subject: [PATCH i-g-t v2] tests/kms_dp_tiled_display: Increase the time limit to
> receive all page flips
> 
> Increasing the time limit from 10us to 20us, within which page flip events must be
> received from all the tiles.
> 
> We've seen that in a few corner cases the test fails with the existing time limit of
> 10us. Increasing the time limit to 20us to accommodate this.
> 
> As the increased time limit of 20us is still in the same blanking interval, there is no
> change in the test functionality.
> 
> v2: Add more justification in the commit message. (uma)

Change looks good.
Reviewed-by: Uma Shankar <uma.shankar at intel.com>

> Signed-off-by: Karthik B S <karthik.b.s at intel.com>
> ---
>  tests/kms_dp_tiled_display.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_dp_tiled_display.c b/tests/kms_dp_tiled_display.c index
> b1160fee..6d19fea6 100644
> --- a/tests/kms_dp_tiled_display.c
> +++ b/tests/kms_dp_tiled_display.c
> @@ -362,9 +362,9 @@ static void page_flip_handler(int fd, unsigned int seq,
> 
>  	/*
>  	 * For seamless tear-free display, the page flip event timestamps
> -	 * from all the tiles should not differ by more than 10us.
> +	 * from all the tiles should not differ by more than 20us.
>  	 */
> -	igt_fail_on_f(labs(usec) >= 10, "Delayed page flip event from CRTC:%d at
> %u:%u\n",
> +	igt_fail_on_f(labs(usec) >= 20, "Delayed page flip event from CRTC:%d
> +at %u:%u\n",
>  		      crtc_id, tv_sec, tv_usec);
>  }
> 
> --
> 2.22.0