[igt-dev] [PATCH i-g-t v3] ts/core_setmaster: new test for drop/set master semantics

Emil Velikov emil.l.velikov at gmail.com
Fri Mar 6 16:32:19 UTC 2020


On Fri, 6 Mar 2020 at 14:28, Petri Latvala <petri.latvala at intel.com> wrote:

> It is _extremely_ likely that we (i915 CI) could sometimes run
> igt at i915_module_load@reload right before this test. Or
> igt at i915_selftest@live. When we do, there's no /dev/dri/card0 at the
> time of chmodding but is at the time of __drm_open_driver().
>
If I understand you correctly, if a test which does rmmod/modprobe
fails, the CI will still continue to run other tests.

Personally it seems to me that any follow-up tests would be
'incorrect' or misleading at the very least.
As such I imagined that the CI will stop at this point.

If that's doable and something people are interested in, as follow-up
one can drop the implicit modprobe from _all_ the drm_open_driver()
calls. Thus getting IGT coverage closer to a real-world use-case - aka
udev does the loading.

Either way, all of this is a brain dump which illustrates my confusion
on the topic.
Thanks a million for the help.

Will send v4 with the workaround + a comment in a moment.

-Emil


More information about the igt-dev mailing list