[igt-dev] [PATCH i-g-t 2/4] lib/rendercopy_gen*: Make cc/viewport static
Chris Wilson
chris at chris-wilson.co.uk
Mon Mar 16 23:11:59 UTC 2020
Quoting Lyude (2020-03-16 16:11:30)
> From: Lyude Paul <lyude at redhat.com>
>
> Since both rendercopy_gen8.c and rendercopy_gen9.c declare cc/viewport
> variables without marking them as static, -fcommon also causes these to
> make our builds fail:
>
> /usr/bin/ld:
> lib/libigt-rendercopy_gen9_c.a(rendercopy_gen9.c.o):lib/rendercopy_gen9.c:46:
> multiple definition of `cc';
> lib/libigt-rendercopy_gen8_c.a(rendercopy_gen8.c.o):lib/rendercopy_gen8.c:45:
> first defined here
> /usr/bin/ld:
> lib/libigt-rendercopy_gen9_c.a(rendercopy_gen9.c.o):lib/rendercopy_gen9.c:51:
> multiple definition of `viewport';
> lib/libigt-rendercopy_gen8_c.a(rendercopy_gen8.c.o):lib/rendercopy_gen8.c:50:
> first defined here
>
> So, fix this by marking them as static.
>
> Signed-off-by: Lyude Paul <lyude at redhat.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris
More information about the igt-dev
mailing list