[igt-dev] [PATCH i-g-t] lib/igt_gt: Add newline to IGT_HANG=0 skips

Chris Wilson chris at chris-wilson.co.uk
Wed May 13 13:20:47 UTC 2020


Quoting Petri Latvala (2020-05-13 14:10:01)
> Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> ---
>  lib/igt_gt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index 2fd51985..70627a8f 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -120,7 +120,7 @@ static void eat_error_state(int dev)
>  void igt_require_hang_ring(int fd, int ring)
>  {
>         if (!igt_check_boolean_env_var("IGT_HANG", true))
> -               igt_skip("hang injection disabled by user");
> +               igt_skip("hang injection disabled by user\n");
>  
>         gem_require_ring(fd, ring);
>         gem_context_require_bannable(fd);
> @@ -175,7 +175,7 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
>         igt_require_gem(fd);
>  
>         if (!igt_check_boolean_env_var("IGT_HANG", true))
> -               igt_skip("hang injection disabled by user");
> +               igt_skip("hang injection disabled by user\n");

Might be worth adding "hang injection disabled by user [IGT_HANG=1]\n"
Environments variable are easy to go unnoticed.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the igt-dev mailing list