[igt-dev] [PATCH i-g-t] lib/igt_params: Fix verifying of debugfs parameters
Petri Latvala
petri.latvala at intel.com
Tue May 19 11:00:56 UTC 2020
On Tue, May 19, 2020 at 01:54:08PM +0300, Juha-Pekka Heikkila wrote:
> After found correct place in debugfs for parameters there
> was used wrong path for verifying existence of parameter
> which caused fallback path to be used.
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> ---
> lib/igt_params.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/igt_params.c b/lib/igt_params.c
> index d8649dfd..410ca650 100644
> --- a/lib/igt_params.c
> +++ b/lib/igt_params.c
> @@ -143,14 +143,14 @@ static int __igt_params_open(int device, char **outpath, const char *param)
>
> devname = openat(dir, "name", O_RDONLY);
> igt_require_f(devname >= 0,
> - "Driver need to name itself in debugfs!");
> + "Driver need to name itself in debugfs!");
>
> read(devname, searchname, sizeof(searchname));
> close(devname);
>
> foundname = strtok_r(searchname, " ", &ctx);
> igt_require_f(foundname,
> - "Driver need to name itself in debugfs!");
> + "Driver need to name itself in debugfs!");
While changing whitespace here, also add the missing \n to the string!
But do take a look at Chris's cleanup patches.
--
Petri Latvala
More information about the igt-dev
mailing list