[igt-dev] [PATCH i-g-t] lib/igt_params: Fix verifying of debugfs parameters

[Petri Latvala]

On Tue, May 19, 2020 at 02:38:45PM +0300, Juha-Pekka Heikkila wrote:
> After found correct place in debugfs for parameters there
> was used wrong path for verifying existence of parameter
> which caused fallback path to be used.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> ---
>  lib/igt_params.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/igt_params.c b/lib/igt_params.c
> index d8649dfd..1f6dc13f 100644
> --- a/lib/igt_params.c
> +++ b/lib/igt_params.c
> @@ -143,14 +143,14 @@ static int __igt_params_open(int device, char **outpath, const char *param)
>  
>  		devname = openat(dir, "name", O_RDONLY);
>  		igt_require_f(devname >= 0,
> -		              "Driver need to name itself in debugfs!");
> +			      "Driver need to name itself in debugfs!\n");
>  
>  		read(devname, searchname, sizeof(searchname));
>  		close(devname);
>  
>  		foundname = strtok_r(searchname, " ", &ctx);
>  		igt_require_f(foundname,
> -		              "Driver need to name itself in debugfs!");
> +			      "Driver need to name itself in debugfs!\n");
>  
>  		snprintf(searchpath, PATH_MAX, "%s_params", foundname);
>  		params = openat(dir, searchpath, O_RDONLY);
> @@ -162,8 +162,8 @@ static int __igt_params_open(int device, char **outpath, const char *param)
>  			if (param != NULL) {
>  				char filepath[PATH_MAX];
>  
> -				snprintf(filepath, PATH_MAX, "%s/%s",
> -					 debugfspath, param);
> +				snprintf(filepath, PATH_MAX, "%s/%s/%s",
> +					 debugfspath, searchpath, param);


Reviewed-by: Petri Latvala <petri.latvala at intel.com>



>  
>  				if (stat(filepath, &buffer) == 0) {
>  					if (outpath != NULL)
> -- 
> 2.26.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev