[igt-dev] [PATCH i-g-t] i915/gem_busy: Remove unnecessary non-preemptible workload

Dominik Grzegorzek dominik.grzegorzek at intel.com
Tue May 19 14:41:57 UTC 2020


Non-preemptible spinners should be avoided as often as possible.
gem_busy at basic has no reason to use non-preemptible workload, only
hung subtests need it.

Signed-off-by: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
---
 tests/i915/gem_busy.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index eb2b6d5c..9e28e2a9 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -347,8 +347,8 @@ static void basic(int fd, const struct intel_execution_engine2 *e, unsigned flag
 	igt_spin_t *spin =
 		igt_spin_new(fd,
 			     .engine = e->flags,
-			     .flags = IGT_SPIN_NO_PREEMPTION |
-			     (flags & HANG ? IGT_SPIN_INVALID_CS : 0));
+			     .flags = flags & HANG ?
+			     IGT_SPIN_NO_PREEMPTION | IGT_SPIN_INVALID_CS : 0);
 	struct timespec tv;
 	int timeout;
 
-- 
2.20.1



More information about the igt-dev mailing list