[igt-dev] [PATCH i-g-t] tests/i915_pm_rpm: Fix plane_subtest assertion

Imre Deak imre.deak at intel.com
Wed May 20 06:56:42 UTC 2020


On Wed, May 20, 2020 at 12:05:41PM +0530, Anshuman Gupta wrote:
> I have added igt_assert_lte() assertion on planes_tested
> unintentionally by mistake, while applying the patch and fixing
> the conflicts.
> 
> Fixes: 32498f12ab04 ("tests/i915_pm_rpm: Fix the universal-plane cap setting in plane tests")
> Cc: Imre Deak <imre.deak at intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta at intel.com>

Reviewed-by: Imre Deak <imre.deak at intel.com>

> ---
>  tests/i915/i915_pm_rpm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index 0a641640..6d46c320 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -1786,7 +1786,7 @@ static void test_one_plane(bool dpms, uint32_t plane_id,
>  /* This one also triggered WARNs on our driver at some point in time. */
>  static void planes_subtest(bool universal, bool dpms)
>  {
> -	int i, planes_tested = 0, crtc_idx;
> +	int i, crtc_idx;
>  	drmModePlaneResPtr planes;
>  
>  	igt_require(default_mode_params);
> @@ -1817,7 +1817,6 @@ static void planes_subtest(bool universal, bool dpms)
>  
>  	igt_assert_eq(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES,
>  				      1), 0);
> -	igt_assert_lte(universal ? 3 : 1, planes_tested);
>  }
>  
>  static void pm_test_tiling(void)
> -- 
> 2.26.0
> 


More information about the igt-dev mailing list