[igt-dev] [PATCH i-g-t 1/4] lib/igt_device_scan: Add missing Check for return value in scan_drm_devices

Lucas De Marchi lucas.de.marchi at gmail.com
Tue May 26 16:06:46 UTC 2020


On Tue, May 26, 2020 at 5:24 AM Arkadiusz Hiler
<arkadiusz.hiler at intel.com> wrote:
>
> From: Ayaz A Siddiqui <ayaz.siddiqui at intel.com>
>
> Return value of udev_enumerate_add_match_property() was not being checked
> in scan_drm_devices().
>
> Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui at intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>

Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

> ---
>  lib/igt_device_scan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index 601d6fb0..7b0fc00e 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -532,7 +532,7 @@ static void scan_drm_devices(void)
>         ret = udev_enumerate_add_match_subsystem(enumerate, "drm");
>         igt_assert(!ret);
>
> -       udev_enumerate_add_match_property(enumerate, "DEVNAME", "/dev/dri/*");
> +       ret = udev_enumerate_add_match_property(enumerate, "DEVNAME", "/dev/dri/*");
>         igt_assert(!ret);
>
>         ret = udev_enumerate_scan_devices(enumerate);
> --
> 2.25.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev



-- 
Lucas De Marchi


More information about the igt-dev mailing list