[igt-dev] [PATCH i-g-t] i915/gem_exec_fence: Reduce non-preemptible workload

Dominik Grzegorzek dominik.grzegorzek at intel.com
Thu May 28 08:27:37 UTC 2020


Non-preemptible spinners should be avoided as often as possible.
gem_exec_fence@[basic-await, nb-await] has no reason to use non-preemptible
workload, only hanging subtests need it.

Signed-off-by: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
---
 tests/i915/gem_exec_fence.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
index ad22f9f5..d70e73a2 100644
--- a/tests/i915/gem_exec_fence.c
+++ b/tests/i915/gem_exec_fence.c
@@ -344,9 +344,10 @@ static void test_fence_await(int fd, const struct intel_execution_engine2 *e,
 
 	spin = igt_spin_new(fd,
 			    .engine = e->flags,
-			    .flags = (IGT_SPIN_FENCE_OUT |
+			    .flags = IGT_SPIN_FENCE_OUT |
+				     (flags & HANG ?
 				      IGT_SPIN_NO_PREEMPTION |
-				      (flags & HANG ? IGT_SPIN_INVALID_CS : 0)));
+				      IGT_SPIN_INVALID_CS : 0));
 	igt_assert(spin->out_fence != -1);
 
 	i = 0;
-- 
2.20.1



More information about the igt-dev mailing list