[igt-dev] [PATCH i-g-t v7 2/2] tests/kms_ccs: CCS Clear Color test

Imre Deak imre.deak at intel.com
Tue Nov 3 14:00:47 UTC 2020


On Tue, Nov 03, 2020 at 03:55:19PM +0200, Kahola, Mika wrote:
> > -----Original Message-----
> > From: Imre Deak <imre.deak at intel.com>
> > Sent: Monday, November 2, 2020 8:13 PM
> > To: Kahola, Mika <mika.kahola at intel.com>
> > Cc: igt-dev at lists.freedesktop.org
> > Subject: Re: [igt-dev] [PATCH i-g-t v7 2/2] tests/kms_ccs: CCS Clear Color test
> > 
> > On Mon, Nov 02, 2020 at 07:27:05PM +0200, Imre Deak wrote:
> > > [...]
> > > On Fri, Oct 23, 2020 at 04:05:26PM +0300, Mika Kahola wrote:
> > > > @@ -274,16 +279,25 @@ gen7_fill_vertex_buffer_data(struct intel_bb
> > *ibb,
> > > >  	offset = intel_bb_offset(ibb);
> > > >
> > > >  	emit_vertex_2s(ibb, dst_x + width, dst_y + height);
> > > > -	emit_vertex_normalized(ibb, src_x + width, intel_buf_width(src));
> > > > -	emit_vertex_normalized(ibb, src_y + height, intel_buf_height(src));
> > > > +
> > > > +	if (src != NULL) {
> > > > +		emit_vertex_normalized(ibb, src_x + width,
> > intel_buf_width(src));
> > > > +		emit_vertex_normalized(ibb, src_y + height,
> > intel_buf_height(src));
> > 
> > The x coords need to be scaled down by 64 pixels, the y coords by 16 lines.
> 
> So you mean that dst coordinates in case of Clear Color should be scaled down, x by 64 pixels and y by 16 lines?

Yes, both x and width by 64 pixels and both y and height by 16 lines.

> 
> > 
> > --Imre
> > 
> > > > +	}
> > >


More information about the igt-dev mailing list