[igt-dev] [PATCH i-g-t 2/2] tools/intel_gpu_top: Fix broken integrated device selection

[Siddiqui, Ayaz A]

> -----Original Message-----
> From: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Sent: Wednesday, November 4, 2020 11:30 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Kempczynski, Zbigniew <zbigniew.kempczynski at intel.com>; Latvala,
> Petri <petri.latvala at intel.com>; Siddiqui, Ayaz A <ayaz.siddiqui at intel.com>;
> Lyude Paul <lyude at redhat.com>
> Subject: [PATCH i-g-t 2/2] tools/intel_gpu_top: Fix broken integrated device
> selection
> 
> Last changes incidentally broke integrated device selection on !discrete
> platforms. Add fallback to select card in discrete / integrated order.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Petri Latvala <petri.latvala at intel.com>
> Cc: Ayaz A Siddiqui <ayaz.siddiqui at intel.com>
> Cc: Lyude Paul <lyude at redhat.com>
> ---
>  tools/intel_gpu_top.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index
> 1b6c8633..298defa4 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1400,7 +1400,9 @@ int main(int argc, char **argv)
>  	} else {
>  		ret = igt_device_find_first_i915_discrete_card(&card);
>  		if (!ret)
> -			fprintf(stderr, "No device filter specified and no
> discrete i915 devices found\n");
> +			ret = igt_device_find_integrated_card(&card);
> +		if (!ret)
> +			fprintf(stderr, "No device filter specified and no
> +discrete/integrated i915 devices found\n");
>  	}
LGTM,
Apart from fixing the issue introduced by previous patch, this patch is
providing better error message then legacy intel_gpu_top.

Reviewed-by: Ayaz A Siddiqui <ayaz.siddiqui at intel.com>
> 
>  	if (!ret) {
> --
> 2.26.0