[igt-dev] [PATCH i-g-t v7 2/2] tests/kms_ccs: CCS Clear Color test

[Imre Deak]

On Thu, Nov 05, 2020 at 03:33:57PM +0200, Kahola, Mika wrote:
> [....]
> > > @@ -274,16 +279,25 @@ gen7_fill_vertex_buffer_data(struct intel_bb
> > *ibb,
> > >  	offset = intel_bb_offset(ibb);
> > >
> > >  	emit_vertex_2s(ibb, dst_x + width, dst_y + height);
> > > -	emit_vertex_normalized(ibb, src_x + width, intel_buf_width(src));
> > > -	emit_vertex_normalized(ibb, src_y + height, intel_buf_height(src));
> > > +
> > > +	if (src != NULL) {
> > > +		emit_vertex_normalized(ibb, src_x + width, intel_buf_width(src));
> > > +		emit_vertex_normalized(ibb, src_y + height, intel_buf_height(src));
> > > +	}
> > 
> > For the !src case you also need to emit the two source vertex elements to
> > keep the VUE format we defined in gen6_emit_vertex_elements().
> 
> In this case we don't have src, what should we define as source vertex
> element? Are those src_*, width/height and intel_buf_width/height()
> just zeros?

Yes, just two 0s in float format, so two emit_vertex(0). The alternative
would be to change the vertex layout, but I think it's simpler this way.

--Imre