[igt-dev] [PATCH i-g-t 1/3] lib: Support multiple filters

Chris Wilson chris at chris-wilson.co.uk
Wed Nov 11 12:03:52 UTC 2020


Quoting Petri Latvala (2020-11-10 08:35:06)
> On Mon, Nov 09, 2020 at 05:02:48PM +0000, Chris Wilson wrote:
> > Quoting Arkadiusz Hiler (2020-05-04 08:37:05)
> > > This patch brings back support for multiple filters that was in the
> > > original series by Zbyszek.
> > 
> > How is this filtering meant to work for tests that try to open two
> > different devices? Shouldn't the igt_device_filter_count() take into
> > account whether the filter even matches the desired device?
> > Should all of the filters include all possible devices?
> 
> 
> If you use filters, and you have two different devices you want to
> use, the test should use drm_open_driver_another() and have filters
> for two devices, semicolon-separated. See kms_prime for a good example
> of the usage.

Why does the test know about filters?

	drm_open_driver(DRIVER_INTEL);
	drm_open_driver(DRIVER_VGEM);

fails to find vgem because some filter is restricting the available set
to intel. And _another still does not overcome an imposed restriction.

I would not call kms_prime a good example. :|
-Chris


More information about the igt-dev mailing list