[igt-dev] [PATCH i-g-t 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such

Lyude Paul lyude at redhat.com
Fri Nov 13 19:00:44 UTC 2020


Reviewed-by: Lyude Paul <lyude at redhat.com>

On Fri, 2020-11-13 at 11:49 -0500, Jeremy Cline wrote:
> Several tests in the addfb suite only apply to i915 devices. Mark them
> as such so these tests are skipped on non-Intel devices.
> 
> Signed-off-by: Jeremy Cline <jcline at redhat.com>
> ---
>  tests/kms_addfb_basic.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 9455909c..0ec583fe 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -572,6 +572,7 @@ static void addfb25_ytile(int fd)
>  
>         igt_subtest("addfb25-y-tiled-legacy") {
>                 igt_require_fb_modifiers(fd);
> +               igt_require_intel(fd);
>  
>                 f.modifier[0] = LOCAL_I915_FORMAT_MOD_Y_TILED;
>                 igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
> @@ -583,6 +584,7 @@ static void addfb25_ytile(int fd)
>  
>         igt_subtest("addfb25-yf-tiled-legacy") {
>                 igt_require_fb_modifiers(fd);
> +               igt_require_intel(fd);
>  
>                 f.modifier[0] = LOCAL_I915_FORMAT_MOD_Yf_TILED;
>                 igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
> @@ -594,6 +596,7 @@ static void addfb25_ytile(int fd)
>  
>         igt_subtest("addfb25-y-tiled-small-legacy") {
>                 igt_require_fb_modifiers(fd);
> +               igt_require_intel(fd);
>  
>                 gen = intel_gen(intel_get_drm_devid(fd));
>                 igt_require(gen >= 9);

-- 
Sincerely,
   Lyude Paul (she/her)
   Software Engineer at Red Hat
   
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!



More information about the igt-dev mailing list