[igt-dev] [PATCH i-g-t]i915/gem_linear_blits: Added description to the subtest

[Katarzyna Dec]

On Thu, Nov 05, 2020 at 10:13:15AM +0530, sai.gowtham.ch at intel.com wrote:
> From: sai gowtham <sai.gowtham.ch at intel.com>
> 
> Added description to basic subtest.
> 
> Cc: Melkaveri Arjun <arjun.melkaveri at intel.com>
> Signed-off-by: sai gowtham <sai.gowtham.ch at intel.com>
> ---
>  tests/i915/gem_linear_blits.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/i915/gem_linear_blits.c b/tests/i915/gem_linear_blits.c
> index cae42d52..9b9d8011 100644
> --- a/tests/i915/gem_linear_blits.c
> +++ b/tests/i915/gem_linear_blits.c
> @@ -215,6 +215,8 @@ igt_main
>  		count = (count + ncpus - 1) / ncpus;
>  	}
>  
> +	igt_describe("This test is to check if the basics work when doing many blits,"
> +		      "	with a working set larger than the aperture size");
In my opinion copy-paste of description from Top to here is waste of time. Gives
no additional information.

It should be more like:

igt_describe("Excercise 2 buffer objects check if driver will reaarange them.");
buffers.");
>  	igt_subtest("basic")
>  		run_test(fd, 2);
While you are already checking this binary, please do the same for other cases.

Hint - investigate file changes wih git-blame.

Kasia 
>  
> -- 
> 2.28.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev