[igt-dev] [PATCH i-g-t] i915/gem_flink_basic: Add subtests description for test case

[Katarzyna Dec]

On Tue, Nov 03, 2020 at 11:28:27PM +0530, apoorva1.singh at intel.com wrote:
> From: Apoorva Singh <apoorva1.singh at intel.com>
> 
Be more expressive in commit msg. Why the change is needed?

> Signed-off-by: Apoorva Singh <apoorva1.singh at intel.com>
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> ---
>  tests/i915/gem_flink_basic.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/i915/gem_flink_basic.c b/tests/i915/gem_flink_basic.c
> index 48b0b8b1..a67fb8fc 100644
> --- a/tests/i915/gem_flink_basic.c
> +++ b/tests/i915/gem_flink_basic.c
> @@ -161,16 +161,24 @@ igt_main
>  	igt_fixture
>  		fd = drm_open_driver(DRIVER_INTEL);
>  
> +	igt_describe("Basic test for GEM_FLINK and GEM_OPEN ioctls");
This description tells what is used, not why or what for.
Let's try one:
igt_describe("Check if gem obj names can be coverted to handles and opened.");

>  	igt_subtest("basic")
>  		test_flink(fd);
> +
For more please refer to Gem Objects naming documentation.
Kasia
> +	igt_describe("Tests that multiple flinks for the same gem object share the same name");
>  	igt_subtest("double-flink")
>  		test_double_flink(fd);
> +
> +	igt_describe("Verify that GEM_FLINK ioctl with invalid gem object retuns relevant error");
>  	igt_subtest("bad-flink")
>  		test_bad_flink(fd);
> +
> +	igt_describe("Verify that GEM_OPEN ioctl with invalid flink name retuns relevant error");
>  	igt_subtest("bad-open")
>  		test_bad_open(fd);
>  
>  	/* Flink lifetime is limited to that of the gem object it points to */
> +	igt_describe("Tests flink lifetime by referencing it from multiple fd's");
>  	igt_subtest("flink-lifetime")
>  		test_flink_lifetime(fd);
>  }
> -- 
> 2.25.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev