[igt-dev] [PATCH i-g-t] i915/gem_exec_gttfill: Added test description for test case

[Katarzyna Dec]

On Thu, Oct 29, 2020 at 10:11:09AM +0530, sai.gowtham.ch at intel.com wrote:
> From: sai gowtham <sai.gowtham.ch at intel.com>
> 
> Added test description to all the subtests.
> 
> Cc: Melkaveri Arjun <arjun.melkaveri at intel.com>
> Signed-off-by: sai gowtham <sai.gowtham.ch at intel.com>
> ---
>  tests/i915/gem_exec_gttfill.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/i915/gem_exec_gttfill.c b/tests/i915/gem_exec_gttfill.c
> index 8f2336a3..e330c973 100644
> --- a/tests/i915/gem_exec_gttfill.c
> +++ b/tests/i915/gem_exec_gttfill.c
> @@ -209,9 +209,13 @@ igt_main
>  		igt_fork_hang_detector(i915);
>  	}
>
Generally it looks good, I would make it a little bit shorter, something like:

> +	igt_describe("This test is to check the basic correctness"
> +			"of handling enough batches to fill gtt");
igt_describe("Check that we can handle enough batches to fill gtt");

Try to do similar below.
Kasia 
>  	igt_subtest("basic") /* just enough to run a single pass */
>  		fillgtt(i915, ALL_ENGINES, 1);
>  
> +	igt_describe("For each engine, it checks the correctness of handling"
> +			"enought batches to fill gtt");
>  	igt_subtest_with_dynamic("engines") {
>  		__for_each_physical_engine(i915, e) {
>  			if (!gem_class_can_store_dword(i915, e->class))
> @@ -222,6 +226,8 @@ igt_main
>  		}
>  	}
>  
> +	igt_describe("This Test is to stress and check behaviour/correctness of handling"
> +			"batches to fill gtt");
>  	igt_subtest("all")
>  		fillgtt(i915, ALL_ENGINES, 20);
>  
> -- 
> 2.28.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev