[igt-dev] [PATCH i-g-t] Added test description for test case.

[Katarzyna Dec]

On Thu, Nov 05, 2020 at 09:58:51AM +0530, sai.gowtham.ch at intel.com wrote:
> From: sai gowtham <sai.gowtham.ch at intel.com>
Name of test missing from patch subject.

> 
> Added test description to test and basic-all subtest
Maybe you could add brief descriptions to all cases?
> 
> Cc: Melkaveri Arjun <arjun.melkaveri at intel.com>
> Signed-off-by: sai gowtham <sai.gowtham.ch at intel.com>
> ---
>  tests/i915/gem_ringfill.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/i915/gem_ringfill.c b/tests/i915/gem_ringfill.c
> index c499cb0d..aebbd15a 100644
> --- a/tests/i915/gem_ringfill.c
> +++ b/tests/i915/gem_ringfill.c
> @@ -50,6 +50,9 @@
>  #define HIBERNATE 0x40
>  #define NEWFD 0x80
>  
> +IGT_TEST_DESCRIPTION("This test does many tiny batchbuffer operations, in the"
> +		" hope of catching failure to manage the ring properly near full");
I would go with:
Do many tiny batchbuffer operations to catch errors while ring is near full.

Of course if that still means the same to you.
> +
>  static unsigned int ring_size;
>  
>  static void check_bo(int fd, uint32_t handle)
> @@ -348,6 +351,8 @@ igt_main
>  		}
>  	}
>  
> +	igt_describe("This test does a basic pass over on all engines simultaniously"
> +			" and checks how the driver handles a full ring.");
In my opinion description it too long, can be shortened.

Kasia
>  	igt_subtest("basic-all") {
>  		const struct intel_execution_engine2 *e;
>  
> -- 
> 2.28.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev