[igt-dev] [PATCH i-g-t, v2] tests/core_auth: Added test description for test case

[Katarzyna Dec]

On Thu, Nov 19, 2020 at 10:18:00AM +0530, priyanka.dandamudi at intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> 
> Added test description to all the available subtests.
> 
> v2:Modified detailed test descriptions to brief one.
> 
> Cc: Katarzyna Dec <katarzyna.dec at intel.com>
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> ---
>  tests/core_auth.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/core_auth.c b/tests/core_auth.c
> index 9c240fdb..c9ad3fb9 100644
> --- a/tests/core_auth.c
> +++ b/tests/core_auth.c
> @@ -195,6 +195,7 @@ igt_main
>  	int master;
>  
>  	/* root (which we run igt as) should always be authenticated */
> +	igt_describe("Check drm client is always authenticated.");
>  	igt_subtest("getclient-simple") {
>  		int fd = drm_open_driver(DRIVER_ANY);
>  
> @@ -203,6 +204,7 @@ igt_main
>  		close(fd);
>  	}
>  
> +	igt_describe("Use 2 clients, check second is authenticated even when first dropped.");
>  	igt_subtest("getclient-master-drop") {
>  		int fd = drm_open_driver(DRIVER_ANY);
>  		int fd2 = drm_open_driver(DRIVER_ANY);
> @@ -220,11 +222,13 @@ igt_main
>  	igt_subtest_group {
>  		igt_fixture
>  			master = drm_open_driver_master(DRIVER_ANY);
> -
> +	
I am not sure about that new line ^ here.
> +		igt_describe("Test magic numbers for master and slave.");
>  		igt_subtest("basic-auth")
>  			test_basic_auth(master);
>  
>  		/* this must be last, we adjust the rlimit */
> +		igt_describe("Test authentication and magic numbers uniqness for rlimit slaves.");
>  		igt_subtest("many-magics")
>  			test_many_magics(master);
>  	}
At the end - it looks ok.
Reviewed-by: Katarzyna Dec <katarzyna.dec at intel.com>

Kasia :)
> -- 
> 2.28.0
>