[igt-dev] [PATCH i-g-t] i915/gem_tiled_blits: Added description of subtests

[Katarzyna Dec]

On Sun, Nov 01, 2020 at 05:44:46PM +0530, apoorva1.singh at intel.com wrote:
> From: Apoorva Singh <apoorva1.singh at intel.com>
> 
> Signed-off-by: Apoorva Singh <apoorva1.singh at intel.com>
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> ---
>  tests/i915/gem_tiled_blits.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/i915/gem_tiled_blits.c b/tests/i915/gem_tiled_blits.c
> index 36e96785..3ea4dcd7 100644
> --- a/tests/i915/gem_tiled_blits.c
> +++ b/tests/i915/gem_tiled_blits.c
> @@ -189,15 +189,23 @@ igt_main
>  		count = (count + ncpus - 1) / ncpus;
>  	}
>  
> +	igt_describe("Validates the content of small number of tiled buffer objects "
> +	       "after random tiled blits among each other");
In my opinion this one is too long, I got lost what is going on.
Info about scenarios is already given at the begining of file:

 * The model is to fill a collection of 1MB objects in a way that can't trip
 * over A6 swizzling -- upload data to a non-tiled object, blit to the tiled
 * object.  Then, copy the 1MB objects randomly between each other for a while.
 * Finally, download their data through linear objects again and see what
 * resulted.

Any idea how to make is shorter, like one sentence?
Basic case is limited with size.

igt_describe("Randomly copy small tiled buffer to catch fence or tiling error. "

What do you think?
Kasia
>  	igt_subtest("basic")
>  		run_test(fd, 2);
>  
> +	igt_describe("Validates the content of large number of tiled buffer objects "
> +	       "(working set larger than the aperture size) after random tiled blits among "
> +	       "each other, performed on multiple parallel threads");
>  	igt_subtest("normal") {
>  		igt_fork(child, ncpus)
>  			run_test(fd, count);
>  		igt_waitchildren();
>  	}
>  
> +	igt_describe("Validates the content of large number of tiled buffer objects "
> +	       "(working set larger than the aperture size) after random tiled blits among "
> +	       "each other, performed on multiple parallel threads in an interrupting environment");
>  	igt_subtest("interruptible") {
>  		igt_fork_signal_helper();
>  		igt_fork(child, ncpus)
> -- 
> 2.25.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev