[igt-dev] [PATCH i-g-t] i915/i915_hangman: Added test description for test case

[Katarzyna Dec]

On Wed, Oct 28, 2020 at 09:16:39PM +0530, apoorva1.singh at intel.com wrote:
> From: Apoorva Singh <apoorva1.singh at intel.com>
> 
> Added test and subtests description
> 
> Signed-off-by: Apoorva Singh <apoorva1.singh at intel.com>
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> ---
>  tests/i915/i915_hangman.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c
> index 2b341c4b..4340d680 100644
> --- a/tests/i915/i915_hangman.c
> +++ b/tests/i915/i915_hangman.c
> @@ -36,6 +36,8 @@
>  #include "igt_sysfs.h"
>  #include "igt_debugfs.h"
>  
> +IGT_TEST_DESCRIPTION("Tests the handling of hang scenarios");
> +
>  #ifndef I915_PARAM_CMD_PARSER_VERSION
>  #define I915_PARAM_CMD_PARSER_VERSION       28
>  #endif
> @@ -274,9 +276,11 @@ igt_main
>  		igt_require(has_error_state(sysfs));
>  	}
>  
> +	igt_describe("Validates the error state after manually triggering a hang");
>  	igt_subtest("error-state-basic")
>  		test_error_state_basic();
>  
> +	igt_describe("For each engine, validates the error state after injecting a hanging batch");
>  	igt_subtest_with_dynamic("error-state-capture") {
>  		__for_each_physical_engine(device, e) {
>  			igt_dynamic_f("%s", e->name)
> @@ -284,6 +288,7 @@ igt_main
>  		}
>  	}
>  
> +	igt_describe("Verify that execution of unterminated batch buffer triggers a hang");
>  	igt_subtest("hangcheck-unterminated")
>  		hangcheck_unterminated();
Maybe too verbose, but LGTM.
Reviewed-by: Katarzyna Dec <katarzyna.dec at intel.com>

Kasia :)

>  
> -- 
> 2.25.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev