[igt-dev] [PATCH i-g-t] i915/gem_mmap: Added test description for test case

[Katarzyna Dec]

On Fri, Sep 04, 2020 at 05:13:24PM +0530, apoorva1.singh at intel.com wrote:
> From: Apoorva Singh <apoorva1.singh at intel.com>
> 
> Added test description to all the available subtests.
> 
> Signed-off-by: Apoorva Singh <apoorva1.singh at intel.com>
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> Cc: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> ---
>  tests/i915/gem_mmap.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/tests/i915/gem_mmap.c b/tests/i915/gem_mmap.c
> index f8cf052e..4ad62ad9 100644
> --- a/tests/i915/gem_mmap.c
> +++ b/tests/i915/gem_mmap.c
> @@ -37,6 +37,8 @@
>  #include <sys/ioctl.h>
>  #include "drm.h"
>  
> +IGT_TEST_DESCRIPTION("Basic MMAP IOCTL tests for memory regions\n");
> +
>  #define OBJECT_SIZE 16384
>  #define PAGE_SIZE 4096
>  int fd;
> @@ -155,6 +157,7 @@ igt_main
>  	igt_fixture
>  		fd = drm_open_driver(DRIVER_INTEL);
>  
> +	igt_describe("Verify mapping to invalid gem objects won't be created");
>  	igt_subtest("bad-object") {
>  		uint32_t real_handle = gem_create(fd, 4096);
>  		uint32_t handles[20];
> @@ -179,6 +182,7 @@ igt_main
>  		gem_close(fd, real_handle);
>  	}
>  
> +	igt_describe("Verify mapping to gem object with invalid offset won't be created");
>  	igt_subtest("bad-offset") {
>  		struct bad_offset {
>  			uint64_t size;
> @@ -206,6 +210,7 @@ igt_main
>  		}
>  	}
>  
> +	igt_describe("Verify mapping to gem object with invalid size won't be created");
>  	igt_subtest("bad-size") {
>  		uint64_t bad_size[] = {
>  			0,
> @@ -229,6 +234,8 @@ igt_main
>  		}
>  	}
>  
> +	igt_describe("Test basics of newly mapped gem object like default content, write and read "
> +	       "coherency, mapping existence after gem_close and unmapping");
>  	igt_subtest("basic") {
>  		struct drm_i915_gem_mmap arg = {
>  			.handle = gem_create(fd, OBJECT_SIZE),
> @@ -256,6 +263,7 @@ igt_main
>  		munmap(addr, OBJECT_SIZE);
>  	}
>  
> +	igt_describe("Verify mapping to gem object is successful using IGT library function");
these are all IGT functions :)
igt_describe("Map small object though direct CPU access, bypassing GPU.");
>  	igt_subtest("short-mmap") {
>  		uint32_t handle = gem_create(fd, OBJECT_SIZE);
>  
> @@ -268,15 +276,27 @@ igt_main
>  		gem_close(fd, handle);
>  	}
>  
> +	igt_describe("Verify initial page faulting completes within a specified time");
igt_describe("Verify that GTT faults are asynchronous to GPU rendering, page
faults completes within specific time.");
>  	igt_subtest("pf-nonblock")
>  		test_pf_nonblock(fd);
>  
> +	igt_describe("Test the write read coherency and simultaneous access of different pages "
> +	       "in a newly mapped basic small buffer object");
I would change second part of sentence to:
" small bo");

Similar change I suggest to make with others. General descriptions look good.
Kasia
>  	igt_subtest("basic-small-bo")
>  		test_huge_bo(-1);
> +
> +	igt_describe("Test the write read coherency and simultaneous access of different pages "
> +	       "in a newly mapped big buffer object");
>  	igt_subtest("big-bo")
>  		test_huge_bo(0);
> +
> +	igt_describe("Test the write read coherency and simultaneous access of different pages "
> +	       "in a newly mapped huge buffer object");
>  	igt_subtest("huge-bo")
>  		test_huge_bo(1);
> +
> +	igt_describe("Test the write read coherency and simultaneous access of different pages "
> +	       "in a newly mapped swap buffer object");
>  	igt_subtest("swap-bo")
>  		test_huge_bo(2);
>  
> -- 
> 2.28.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev