[igt-dev] [PATCH i-g-t] i915/gem_mmap_wc: Align subtests with correct function calls

Chris Wilson chris at chris-wilson.co.uk
Mon Oct 5 13:42:00 UTC 2020


Quoting apoorva1.singh at intel.com (2020-09-09 09:31:25)
> From: Apoorva Singh <apoorva1.singh at intel.com>
> 
> - Fix the name of subtest "write-gtt-read-gtt"
> - Fix subtests "write-wc-read-gtt" and "write-gtt-read-gtt"
> to call correct fucntions
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> Signed-off-by: Apoorva Singh <apoorva1.singh at intel.com>
> ---
>  tests/i915/gem_mmap_wc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/i915/gem_mmap_wc.c b/tests/i915/gem_mmap_wc.c
> index f44b406d..c940376a 100644
> --- a/tests/i915/gem_mmap_wc.c
> +++ b/tests/i915/gem_mmap_wc.c
> @@ -329,7 +329,7 @@ test_write_cpu_read_wc(int fd, int force_domain)
>  }
>  
>  static void
> -test_write_gtt_read_wc(int fd)
> +test_write_wc_read_gtt(int fd)
>  {
>         uint32_t handle;
>         uint32_t *src, *dst;
> @@ -350,7 +350,7 @@ test_write_gtt_read_wc(int fd)
>  }
>  
>  static void
> -test_write_wc_read_gtt(int fd)
> +test_write_gtt_read_wc(int fd)

Bleugh; probably better to also not call them src/dst.
-Chris


More information about the igt-dev mailing list