[igt-dev] [i-g-t] tests: Remove kms_crtc_background_color test

[Petri Latvala]

On Wed, Oct 07, 2020 at 11:56:08AM +0300, Laxminarayan Bharadiya, Pankaj wrote:
> 
> 
> > -----Original Message-----
> > From: Matt Roper <matthew.d.roper at intel.com>
> > Sent: 03 September 2020 07:23
> > To: Peres, Martin <martin.peres at intel.com>
> > Cc: Laxminarayan Bharadiya, Pankaj
> > <pankaj.laxminarayan.bharadiya at intel.com>; Sharma, Swati2
> > <swati2.sharma at intel.com>; igt-dev at lists.freedesktop.org
> > Subject: Re: [igt-dev] [i-g-t] tests: Remove kms_crtc_background_color test
> > 
> > On Wed, Sep 02, 2020 at 04:58:35AM -0700, Peres, Martin wrote:
> > > +Matt
> > >
> > > Hi everyone,
> > >
> > > On 2020-09-02 11:34, Laxminarayan Bharadiya, Pankaj wrote:
> > > >> -----Original Message-----
> > > >> From: Sharma, Swati2 <swati2.sharma at intel.com>
> > > >> Sent: 02 September 2020 13:59
> > > >> To: Laxminarayan Bharadiya, Pankaj
> > > >> <pankaj.laxminarayan.bharadiya at intel.com>;
> > > >> igt-dev at lists.freedesktop.org; Martin Peres
> > > >> <martin.peres at linux.intel.com>
> > > >> Subject: Re: [igt-dev] [i-g-t] tests: Remove
> > > >> kms_crtc_background_color test
> > > >>
> > > >>
> > > >>
> > > >> On 28-Jul-20 8:53 PM, Pankaj Bharadiya wrote:
> > > >>> BACKGROUND_COLOR property is not supported in kernel as of now.
> > > >>> Following patch attempted to add support but never got merged due
> > > >>> to lack of userspace support.
> > > >>>
> > > >>>
> > https://patchwork.freedesktop.org/patch/333632/?series=67424&rev=1
> > > >>>
> > > >>> This test case is always skipped, as it does not find the
> > > >>> BACKGROUND_COLOR prop support hence remove it.
> > > >>
> > > >> Why we have to remove the test? What if its supported in kernel in
> > future?
> > > >> If test is skipping; we can add it to blacklist (listing it as
> > > >> expected
> > > >> skip)
> > > >
> > > > IMO, first of all, this code should not have been added unless kernel
> > supports it.
> > > > It's a dead code.
> > > >
> > > > I don’t think there a plan to add BACKGROUND_COLOR property in
> > > > kernel since we don't have any reference user space implantation which
> > uses/need this property.
> > >
> > > I tend to agree with Pankaj here. The code won't be gone, and this
> > > patch can be reverted when the property lands in at least one DRM driver.
> > >
> > > That being said, please make sure with Matt that no activity is going
> > > on around this property before landing this patch. If so, then this patch is:
> > 
> > Yeah, go ahead and remove it.  There is software out there that uses the
> > property, but it's all closed-source software, so the kernel support has never
> > been upstreamable and only exists in product group kernels.
> > 
> > It seems every couple years someone comes along and shows interest in
> > using the functionality in open source userspace, so we put effort into
> > refreshing the patches and resubmitting them upstream, but ultimately the
> > userspace efforts fizzle out and the kernel code goes back on ice.
> > I'm not aware of any specific interest at the moment, and if this does get
> > resurrected again in the future we can just write new IGT support for it then
> > (my last couple upstream respins also included complete overhauls of the
> > IGT support, so the old snapshot that's already present in upsteam IGT isn't
> > even really useful if the kernel support does come back).
> > 
> > For the removal:
> > Acked-by: Matt Roper <matthew.d.roper at intel.com>
> 
> Can this patch be merged please?

Thanks for the poke, merged now.


-- 
Petri Latvala