[igt-dev] [PATCH i-g-t 06/24] lib/intel_allocator: Add intel_allocator core

[Chris Wilson]

Quoting Petri Latvala (2020-10-22 11:09:56)
> On Thu, Oct 22, 2020 at 11:58:49AM +0200, Zbigniew Kempczyński wrote:
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> > Signed-off-by: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Petri Latvala <petri.latvala at intel.com>
> > ---
> >  .../igt-gpu-tools/igt-gpu-tools-docs.xml      |   1 +
> >  lib/igt_core.c                                |   2 +
> >  lib/intel_allocator.c                         | 939 ++++++++++++++++++
> >  lib/intel_allocator.h                         | 136 +++
> >  lib/intel_allocator_msgchannel.c              | 182 ++++
> >  lib/intel_allocator_msgchannel.h              | 140 +++
> >  lib/intel_allocator_simple.c                  |   2 -
> >  lib/meson.build                               |   4 +
> >  8 files changed, 1404 insertions(+), 2 deletions(-)
> >  create mode 100644 lib/intel_allocator.c
> >  create mode 100644 lib/intel_allocator.h
> >  create mode 100644 lib/intel_allocator_msgchannel.c
> >  create mode 100644 lib/intel_allocator_msgchannel.h
> > 
> > diff --git a/docs/reference/igt-gpu-tools/igt-gpu-tools-docs.xml b/docs/reference/igt-gpu-tools/igt-gpu-tools-docs.xml
> > index bf5ac542..192d1df7 100644
> > --- a/docs/reference/igt-gpu-tools/igt-gpu-tools-docs.xml
> > +++ b/docs/reference/igt-gpu-tools/igt-gpu-tools-docs.xml
> > @@ -43,6 +43,7 @@
> >      <xi:include href="xml/igt_vc4.xml"/>
> >      <xi:include href="xml/igt_vgem.xml"/>
> >      <xi:include href="xml/igt_x86.xml"/>
> > +    <xi:include href="xml/intel_allocator.xml"/>
> >      <xi:include href="xml/intel_batchbuffer.xml"/>
> >      <xi:include href="xml/intel_bufops.xml"/>
> >      <xi:include href="xml/intel_chipset.xml"/>
> > diff --git a/lib/igt_core.c b/lib/igt_core.c
> > index 1f725d00..86653abc 100644
> > --- a/lib/igt_core.c
> > +++ b/lib/igt_core.c
> > @@ -1414,6 +1414,8 @@ static void exit_subtest(const char *result)
> >       }
> >       num_test_children = 0;
> >  
> > +     intel_allocator_init();
> > +
> >       if (!in_dynamic_subtest)
> >               _igt_dynamic_tests_executed = -1;
> >  
> 
> Just drive-by commenting for others that might be as confused about
> this as I was: intel_allocator_init call is only added to exit_subtest
> because the first call to it is already done in an igt_constructor
> block.

So that's a hint for a comment :)
-Chris