[igt-dev] [PATCH i-g-t] tests/kms_psr2_su: Skip frontbuffer test in TGL

Petri Latvala petri.latvala at intel.com
Wed Oct 28 07:37:51 UTC 2020


On Tue, Oct 27, 2020 at 07:07:14PM +0200, Souza, Jose wrote:
> On Tue, 2020-10-27 at 10:49 +0200, Petri Latvala wrote:
> > On Mon, Oct 26, 2020 at 07:47:15PM +0200, Souza, Jose wrote:
> > > On Mon, 2020-10-26 at 10:34 +0200, Petri Latvala wrote:
> > > > On Fri, Oct 23, 2020 at 04:11:51PM -0700, José Roberto de Souza wrote:
> > > > > Due the commit 71c1a4998320 ("drm/i915/tgl/psr: Fix glitches when
> > > > > doing frontbuffer modifications"), frontbuffer test is expected to
> > > > > fail on TGL, so here skiping this test on TGL.
> > > > > When PSR issues is fixed the patch above will be reverted and we
> > > > > can revert this skip too.
> > > > 
> > > > How does the previous failure behave? I mean in the sense that what
> > > > does this skip gain? The skip will have to be cibuglog-filtered too so
> > > > no gain on that side.
> > > > 
> > > > Did the fail kill the machine, or is this just for saving runtime?
> > > 
> > > Just saving time.
> > > So no need for it?
> > 
> > Depends on the amount. Do you have numbers for this? I guess if it
> > saves entire minutes it becomes worth it.
> > 
> > 
> 
> Takes about one second when fails a little less when it was passing on TGL.
> Just want to avoid a new freedesktop issue to be filed, we are tracking the right kernel fix in Jira. 

Skip would also need a new fdo issue on platforms >= ICL. Let's just let it fail.


-- 
Petri Latvala


More information about the igt-dev mailing list