[igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc

Dixit, Ashutosh ashutosh.dixit at intel.com
Fri Oct 30 23:06:29 UTC 2020


On Fri, 30 Oct 2020 15:55:48 -0700, Umesh Nerlige Ramappa wrote:
> @@ -4806,6 +4807,13 @@ igt_main
>	igt_fixture {
>		struct stat sb;
>
> +		/*
> +		 * Prior tests may have unloaded i915 or failed while
> +		 * loading/unloading i915. Load i915 here before we stat the
> +		 * files.
> +		 */
> +		igt_i915_driver_load(NULL);
> +

I was thinking that the original if () was also ok because there will be an
additional igt_debug() if the module is already loaded and the if will
avoid that. Anyway you decide what to do, either way:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>


More information about the igt-dev mailing list