[igt-dev] [PATCH i-g-t] lib/i915/perf: rework perf counters equations

[Lionel Landwerlin]

On 10/09/2020 13:58, Petri Latvala wrote:
> On Thu, Sep 10, 2020 at 01:54:00PM +0300, Lionel Landwerlin wrote:
>> On 10/09/2020 13:41, Petri Latvala wrote:
>>> On Thu, Sep 10, 2020 at 01:15:32PM +0300, Lionel Landwerlin wrote:
>>>> Working with an offset means we can have the PERFCNT snapshots stored
>>>> at an offset in the existing accumulator rather than having a specific
>>>> accumulator just for them.
>>>>
>>>> This isn't really useful for IGT because it only looks at the OA
>>>> buffer where those registers aren't stored, but it is useful for perf
>>>> queries in Mesa.
>>>>
>>>> This bumps the version of the i915_perf library to reflect the API
>>>> change (see perf.h).
>>> For older versions of Mesa that cannot use this version, what's the
>>> method of getting a compatible i915-perf? Is it "checkout this older
>>> git commit"?
>>>
>>>
>> Mesa doesn't use the igt library (so far it's only used by the tools &
>> gpuvis), only pulling in the xml files at given point.
> Ah, right.
>
> I'm making an assumption that you tested both gpuvis and Mesa with
> this change so
>
> Acked-by: Petri Latvala <petri.latvala at intel.com>

I did, but forgot to bump the SO version just to make sure apps recompile ;)


-Lionel