[igt-dev] [PATCH i-g-t v2 01/20] Remove unused intel_bufmgr.h headers

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Fri Sep 18 07:20:37 UTC 2020


On Thu, Sep 17, 2020 at 03:06:52PM +0200, Dominik Grzegorzek wrote:
> Delete intel_bufmgr include where it is not necessary.
> 
> Signed-off-by: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  benchmarks/gem_userptr_benchmark.c | 1 -
>  lib/media_fill.c                   | 1 -
>  tests/i915/gem_create.c            | 1 -
>  tests/i915/gem_flink_race.c        | 2 --
>  tests/i915/gem_request_retire.c    | 1 -
>  tests/i915/gem_userptr_blits.c     | 1 -
>  tests/i915/i915_getparams_basic.c  | 1 -
>  tests/kms_sequence.c               | 2 --
>  tests/kms_setmode.c                | 1 -
>  tests/kms_vblank.c                 | 2 --
>  10 files changed, 13 deletions(-)

Looks good.

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew
> 
> diff --git a/benchmarks/gem_userptr_benchmark.c b/benchmarks/gem_userptr_benchmark.c
> index eccc65be..d7a49520 100644
> --- a/benchmarks/gem_userptr_benchmark.c
> +++ b/benchmarks/gem_userptr_benchmark.c
> @@ -48,7 +48,6 @@
>  #include "i915_drm.h"
>  
>  #include "drmtest.h"
> -#include "intel_bufmgr.h"
>  #include "intel_batchbuffer.h"
>  #include "intel_chipset.h"
>  #include "ioctl_wrappers.h"
> diff --git a/lib/media_fill.c b/lib/media_fill.c
> index c21de54b..c4883874 100644
> --- a/lib/media_fill.c
> +++ b/lib/media_fill.c
> @@ -22,7 +22,6 @@
>   *
>   */
>  
> -#include <intel_bufmgr.h>
>  #include <i915_drm.h>
>  
>  #include "media_fill.h"
> diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
> index c7444d55..dc945ab6 100644
> --- a/tests/i915/gem_create.c
> +++ b/tests/i915/gem_create.c
> @@ -47,7 +47,6 @@
>  #include "drm.h"
>  #include "drmtest.h"
>  #include "ioctl_wrappers.h"
> -#include "intel_bufmgr.h"
>  #include "intel_batchbuffer.h"
>  #include "intel_io.h"
>  #include "intel_chipset.h"
> diff --git a/tests/i915/gem_flink_race.c b/tests/i915/gem_flink_race.c
> index c1f5d5d5..de64443d 100644
> --- a/tests/i915/gem_flink_race.c
> +++ b/tests/i915/gem_flink_race.c
> @@ -33,8 +33,6 @@
>  #include <pthread.h>
>  #include <errno.h>
>  
> -#include "intel_bufmgr.h"
> -
>  IGT_TEST_DESCRIPTION("Check for flink/open vs. gem close races.");
>  
>  /* Testcase: check for flink/open vs. gem close races
> diff --git a/tests/i915/gem_request_retire.c b/tests/i915/gem_request_retire.c
> index 4a1ec115..31fb4198 100644
> --- a/tests/i915/gem_request_retire.c
> +++ b/tests/i915/gem_request_retire.c
> @@ -48,7 +48,6 @@
>  
>  #include "i915/gem.h"
>  #include "igt.h"
> -#include "intel_bufmgr.h"
>  
>  IGT_TEST_DESCRIPTION("Collection of tests targeting request retirement code"
>  		     " paths.");
> diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c
> index 268423dc..65272c1b 100644
> --- a/tests/i915/gem_userptr_blits.c
> +++ b/tests/i915/gem_userptr_blits.c
> @@ -62,7 +62,6 @@
>  
>  #include "i915/gem.h"
>  #include "igt.h"
> -#include "intel_bufmgr.h"
>  #include "sw_sync.h"
>  
>  #include "eviction_common.c"
> diff --git a/tests/i915/i915_getparams_basic.c b/tests/i915/i915_getparams_basic.c
> index 7cb210df..e1b4634f 100644
> --- a/tests/i915/i915_getparams_basic.c
> +++ b/tests/i915/i915_getparams_basic.c
> @@ -30,7 +30,6 @@
>  #include <errno.h>
>  #include <xf86drm.h>
>  #include <i915_drm.h>
> -#include "intel_bufmgr.h"
>  
>  IGT_TEST_DESCRIPTION("Tests the export of parameters via DRM_IOCTL_I915_GETPARAM\n");
>  
> diff --git a/tests/kms_sequence.c b/tests/kms_sequence.c
> index a21ab55c..081bd9d7 100644
> --- a/tests/kms_sequence.c
> +++ b/tests/kms_sequence.c
> @@ -42,8 +42,6 @@
>  
>  #include <drm.h>
>  
> -#include "intel_bufmgr.h"
> -
>  IGT_TEST_DESCRIPTION("Test CrtcGetSequence and CrtcQueueSequence.");
>  
>  typedef struct {
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> index 92f3ead2..00dfedd5 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -30,7 +30,6 @@
>  #include <string.h>
>  #include <sys/time.h>
>  #include <math.h>
> -#include "intel_bufmgr.h"
>  
>  #define MAX_CONNECTORS  10
>  #define MAX_CRTCS       6
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> index be001312..b00ebec5 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -41,8 +41,6 @@
>  
>  #include <drm.h>
>  
> -#include "intel_bufmgr.h"
> -
>  IGT_TEST_DESCRIPTION("Test speed of WaitVblank.");
>  
>  typedef struct {
> -- 
> 2.20.1
> 


More information about the igt-dev mailing list