[igt-dev] [PATCH i-g-t] i915/gem_close: Added test description for test case

Melkaveri, Arjun arjun.melkaveri at intel.com
Mon Sep 28 07:45:16 UTC 2020


On Thu, Sep 24, 2020 at 02:42:40PM +0530, priyanka.dandamudi at intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> 
> Added test description for test and to all the available subtests.
> 
> v2:Modified basic subtest description.
> 
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> ---
>  tests/i915/gem_close.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/i915/gem_close.c b/tests/i915/gem_close.c
> index 58f2d4b3..76b0979a 100644
> --- a/tests/i915/gem_close.c
> +++ b/tests/i915/gem_close.c
> @@ -24,6 +24,9 @@
>  #include "i915/gem.h"
>  #include "igt.h"
>  
> +IGT_TEST_DESCRIPTION("Tests basic gem_close ioctl by closing the gem buffer handle "
> +		     "and also tests if duplicate handles are operational when original is closed.");
> +
>  static int batch_create(int fd)
>  {
>  	const uint32_t bbe = MI_BATCH_BUFFER_END;
> @@ -132,9 +135,14 @@ igt_main
>  		igt_require_gem(fd);
>  	}
>  
> +	igt_describe("Tests the basic working of gem_close ioctl." 
> +		      "which releases a file-private gem buffer handle.");
>  	igt_subtest("basic")
>  		gem_close(fd, gem_create(fd, 4096));
>  
> +	igt_describe(" The test creates duplicate handles of up to 128 for the same object "
> +		     "and checks if only permissible duplicate handles are allowed. "
> +		     "It also checks if duplicate handles are operational when original is closed.");
>  	igt_subtest("many-handles-one-vma")
>  		test_many_handles(fd);
>  }
Looks good 
Reviewed-by: Arjun Melkaveri <arjun.melkaveri at intel.com>
> -- 
> 2.28.0
> 


More information about the igt-dev mailing list