[igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter

[Zbigniew Kempczyński]

On Mon, Sep 28, 2020 at 02:13:26PM -0700, Dixit, Ashutosh wrote:
> On Thu, 03 Sep 2020 04:54:09 -0700, Zbigniew Kempczyński wrote:
> >
> > On Thu, Sep 03, 2020 at 04:31:09PM +0530, Ayaz A Siddiqui wrote:
> > > DRM subsystem filter in intel_gpu_top was not working due to missing
> > > PCI_SLOT_NAME property. Using the parent device in case of drm subsystem
> > > leads to fix this issue.
> > >
> > > Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui at intel.com>
> > > ---
> > >  lib/igt_device_scan.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> > > index 345bae76d..3583c69c7 100644
> > > --- a/lib/igt_device_scan.c
> > > +++ b/lib/igt_device_scan.c
> > > @@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter, struct igt_device_card *card)
> > >	/* We take first one if more than one card matches filter */
> > >	dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
> > >
> > > -	__copy_dev_to_card(dev, card);
> > > +	__copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent, card);
> > >
> > >	return true;
> > >  }
> >
> > The only doubt I got: - is that i915 driver behavior or all drm cards do
> > the same?
> 
> I am not entirely sure but I will be very surprised if this is i915 driver
> behavior. I'd think this is a property of the drm subsystem.

Likely you're right, I've check on another vendor and it looks same. 
But is_pci_subsystem(dev) can be wrong on !pci devices. Perhaps it not 
the case now but for other filter for platform devices it likely be
wrong.

--
Zbigniew