[igt-dev] [PATCH] Revert "Add eDP support in Link Layer Compliance Tool"

[Petri Latvala]

On Thu, Apr 01, 2021 at 11:21:41AM -0700, Khaled Almahallawy wrote:
> The eDP change didn’t take into account choosing the right CRTC when compliance is requested on external DP.
> This causes Hotplug Uevent sent from the kernel (intel_dp_short_pulse) to always trigger LT on eDP.
> Without reverting this change the only way to run compliance on external display is to disconnect the eDP cable which is pain for ODMs.
> 
> So reverting this change until a full solution that handles multiple connected displays in place.
> 
> This reverts commit 391929b7402fd0417dcb9026c202241413653942.
> 
> Signed-off-by: Khaled Almahallawy <khaled.almahallawy at intel.com>

Acked-by: Petri Latvala <petri.latvala at intel.com>

> ---
>  tools/intel_dp_compliance.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/intel_dp_compliance.c b/tools/intel_dp_compliance.c
> index 217a12479a2d..fb9460561c29 100644
> --- a/tools/intel_dp_compliance.c
> +++ b/tools/intel_dp_compliance.c
> @@ -709,8 +709,7 @@ int update_display(int mode, bool is_compliance_test)
>  		conn = &connectors[cnt];
>  		conn->id = resources->connectors[cnt];
>  		c = drmModeGetConnector(drm_fd, conn->id);
> -		if ((c->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> -		    c->connector_type == DRM_MODE_CONNECTOR_eDP) &&
> +		if (c->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
>  		    c->connection == DRM_MODE_CONNECTED) {
>  			test_connector_id = c->connector_id;
>  			conn->connector = c;
> -- 
> 2.25.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev