[igt-dev] [PATCH i-g-t 02/14] tools/intel_display_poller: Unify ilk+ and bdw+ codepaths

[Navare, Manasi]

On Mon, Mar 01, 2021 at 12:37:35PM -0800, Manasi Navare wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> The ilk+ and bdw+ codepaths are identical, except for the ilk/snb
> pipe C check. Unify them.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Cleanup looks good to me

Reviewed-by: Manasi Navare <manasi.d.navare at intel.com>

Manasi

> ---
>  tools/intel_display_poller.c | 26 +-------------------------
>  1 file changed, 1 insertion(+), 25 deletions(-)
> 
> diff --git a/tools/intel_display_poller.c b/tools/intel_display_poller.c
> index 15da8e76..bb115598 100644
> --- a/tools/intel_display_poller.c
> +++ b/tools/intel_display_poller.c
> @@ -1128,8 +1128,7 @@ int main(int argc, char *argv[])
>  		default:
>  			usage(argv[0]);
>  		}
> -	} else if (HAS_PCH_SPLIT(devid) &&
> -		   (IS_GEN5(devid) || IS_GEN6(devid) || IS_GEN7(devid))) {
> +	} else {
>  		if (pipe > 1 &&
>  		    (IS_GEN5(devid) || IS_GEN6(devid)))
>  			usage(argv[0]);
> @@ -1154,29 +1153,6 @@ int main(int argc, char *argv[])
>  		default:
>  			usage(argv[0]);
>  		}
> -	} else if (intel_gen(devid) >= 8) {
> -		if (test_pixelcount)
> -			usage(argv[0]);
> -
> -		switch (test) {
> -		case TEST_IIR:
> -			test = TEST_DEIIR;
> -			break;
> -		case TEST_FRAMECOUNT:
> -			test = TEST_FRAMECOUNT_G4X;
> -			break;
> -		case TEST_FLIPCOUNT:
> -		case TEST_PAN:
> -		case TEST_FLIP:
> -		case TEST_SURFLIVE:
> -		case TEST_WRAP:
> -		case TEST_FIELD:
> -			break;
> -		default:
> -			usage(argv[0]);
> -		}
> -	} else {
> -		usage(argv[0]);
>  	}
>  
>  	switch (test) {
> -- 
> 2.19.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev