[igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add subtest description

Gupta, Nidhi1 nidhi1.gupta at intel.com
Mon Apr 12 02:40:37 UTC 2021



-----Original Message-----
From: Arundhati Hagaragi <arundhati.hagaragi at intel.com> 
Sent: Friday, April 9, 2021 11:56 PM
To: igt-dev at lists.freedesktop.org
Cc: Hagaragi, Arundhati <arundhati.hagaragi at intel.com>; Gupta; Gupta, Nidhi1 <nidhi1.gupta at intel.com>
Subject: [PATCH i-g-t] tests/kms_big_fb: Add subtest description

Added description for all subtests

Signed-off-by: Arundhati Hagaragi <arundhati.hagaragi at intel.com>
Cc: Gupta, Nidhi1 <nidhi1.gupta at intel.com>
---
The description looks good to me.
Reviewed-by: Nidhi Gupta 

 tests/kms_big_fb.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index 5260176e..001673f7 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -673,6 +673,7 @@ igt_main
 	 * and thus the kenrnel rounding up to the next tile
 	 * height won't do anything.
 	 */
+	igt_describe("Sanity check if addfb ioctl fails correctly for given 
+modifier with small bo");
 	for (int i = 1; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb-size-overflow",
 			      modifiers[i].name) {
@@ -681,6 +682,7 @@ igt_main
 		}
 	}
 
+	igt_describe("Sanity check if addfb ioctl fails correctly for given 
+modifier and offsets with small bo");
 	for (int i = 1; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb-size-offset-overflow",
 			      modifiers[i].name) {
@@ -689,6 +691,7 @@ igt_main
 		}
 	}
 
+	igt_describe("Sanity check if addfb ioctl works correctly for given 
+size and strides of fb");
 	for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb", modifiers[i].name) {
 			data.modifier = modifiers[i].modifier; @@ -706,6 +709,8 @@ igt_main
 			for (int k = 0; k < ARRAY_SIZE(rotations); k++) {
 				data.rotation = rotations[k].rotation;
 
+				igt_describe("Sanity check if addfb ioctl works correctly for given "
+						"combination of modifier formats and rotation");
 				igt_subtest_f("%s-%dbpp-rotate-%d", modifiers[i].name,
 					      formats[j].bpp, rotations[k].angle) {
 					igt_require(data.format == DRM_FORMAT_C8 ||
--
2.25.1



More information about the igt-dev mailing list