[igt-dev] [PATCH i-g-t 2/6] tests/kms_flip_scaled_crc: Don't leak the fbs between subtests

Ville Syrjala ville.syrjala at linux.intel.com
Fri Apr 16 17:53:08 UTC 2021


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

Clean up the fbs properly before starting the next subtest, otherwise
it'll keep using the old fb and not even testing what it claims to be
testing.

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 tests/kms_flip_scaled_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_flip_scaled_crc.c b/tests/kms_flip_scaled_crc.c
index 8153fb890a17..2b3087eb7b54 100644
--- a/tests/kms_flip_scaled_crc.c
+++ b/tests/kms_flip_scaled_crc.c
@@ -223,11 +223,11 @@ igt_main
 	for (int index = 0; index < ARRAY_SIZE(flip_scenario_test); index++) {
 		igt_describe(flip_scenario_test[index].describe);
 		igt_subtest(flip_scenario_test[index].name) {
+			free_fbs(&data);
 			for_each_pipe_with_single_output(&data.display, pipe,
 							 output)
 				test_flip_to_scaled(&data, index, pipe, output);
 
-			free_fbs(&data);
 		}
 	}
 	igt_fixture {
-- 
2.26.3



More information about the igt-dev mailing list