[igt-dev] [PATCH i-g-t v2 05/15] Add MI_SET_APPID instruction definition

[Teres Alexis, Alan Previn]

Thanks - will fix those up.
...alan

On Wed, 2021-04-21 at 08:30 -0400, Rodrigo Vivi wrote:
> On Wed, Mar 24, 2021 at 10:45:39PM -0700, Alan Previn wrote:
> > Add MI_SET_APPID instruction and param definitions
> > 
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis at intel.com>
> > ---
> >  lib/intel_reg.h | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/lib/intel_reg.h b/lib/intel_reg.h
> > index ac1fc6cb..553f4839 100644
> > --- a/lib/intel_reg.h
> > +++ b/lib/intel_reg.h
> > @@ -2546,6 +2546,15 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> > SOFTWARE.
> >  #define CTXT_PALETTE_SAVE_DISABLE	(1<<3)
> >  #define CTXT_PALETTE_RESTORE_DISABLE	(1<<2)
> >  
> > +#define MI_SET_APPID                    (0x0e<<23)
> 
> The trend is to add the new ones with space (0x0E << 23)
> 
> > +#define APPID_CTXSAVE_INHIBIT           (1<<8)
> > +#define APPID_CTXREST_INHIBIT           (1<<9)
> > +#define DISPLAY_APPTYPE                 (0)
> > +#define TRANSCODE_APPTYPE               (1)
> > +#define APPTYPE(n)                      ((n & 0x1)<<7)
> 
> please remove the useless & 0x1
> 
> with that
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> 
> 
> 
> > +#define APPID(n)                        (n & 0x7f)
> > +
> > +
> >  /* Dword 0 */
> >  #define MI_VERTEX_BUFFER		(0x17<<23)
> >  #define MI_VERTEX_BUFFER_IDX(x)		(x<<20)
> > -- 
> > 2.25.1
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev