[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v3,1/3] lib/kms: Commit primary plane props with COMMIT_LEGACY

[Daniel Vetter]

On Wed, Apr 21, 2021 at 08:11:10PM +0300, Ville Syrjälä wrote:
> On Wed, Apr 21, 2021 at 03:42:56AM -0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: series starting with [i-g-t,v3,1/3] lib/kms: Commit primary plane props with COMMIT_LEGACY
> > URL   : https://patchwork.freedesktop.org/series/89278/
> > State : success
> 
> So apparently avoiding those two redundant color encoding/range
> setprop ioctls when chaging the fb does avoid the test failure
> on glk. How on earth two setprop ioctl can do this is a mystery
> The setprops should essentially be nops, and should just result
> in reprogramming the plane registers a few times using an
> identical state.

Might we need a full modeset for the hw to pick them up perhaps? Or at
least plane enable/disable cycle. Doesn't make sense, but hey hw, maybe it
only picks these up on initial enable.

Only other thing I can think of is to maybe double check the state
readout to make sure we really program this correctly in both cases.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch