[igt-dev] [PATCH v2] tests/kms_atomic_transition: Enable Primary Plane on Enabling CRTC.

[Ville Syrjälä]

On Thu, Apr 22, 2021 at 09:13:13AM +0300, Petri Latvala wrote:
> On Fri, Apr 16, 2021 at 01:27:24PM -0400, Mark Yacoub wrote:
> > From: Mark Yacoub <markyacoub at google.com>
> > 
> > Setup all plane params before committing anything.
> > Do not disable Primary Plane whenever a CRTC is getting enabled.
> > 
> > AMD Driver requires the primary plane to be enabled whenever the CRTC is, otherwise
> > drm_mode_cursor_universal may end up trying to enable the cursor plane while all other
> > planes are disabled, which is not supported by the hardware.
> > 
> > === Changes from v1 ===
> > Remove product names from commit message
> > 
> > Cc: Nicholas.Kazlauskas at amd.com
> > ---
> >  tests/kms_atomic_transition.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> 
> I've asked Intel display folks to chime in whether i915 needs any of
> this flow needs to be unchanged with is_i915_device(), no response
> yet.

Dunno if anyone but Maarten knows what the test does exactly.

In general I'd prefer there was some generic way to handle the
"primary plane can't be disabled" thing so that we wouldn't need
special logic/always forcing the primary plane on in all tests.
But I'm not sure if we could easily add some kind TEST_ONLY probe
into igt_display_require()+make igt_kms just automagically enable
the plane when needed for this...

I'm slightly tempted to even suggest that maybe the kernel driver
should just handle this by always keeping the plane on but force
it to scan out black when it's logically disabled...

-- 
Ville Syrjälä
Intel