[igt-dev] [v3 i-g-t 00/14] Fix mode selection for 2x tests

Modem, Bhanuprakash bhanuprakash.modem at intel.com
Wed Apr 28 08:11:57 UTC 2021


> From: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Sent: Monday, April 26, 2021 11:51 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>; Deak, Imre
> <imre.deak at intel.com>; Nautiyal, Ankit K <ankit.k.nautiyal at intel.com>; Daniel
> Vetter <daniel.vetter at ffwll.ch>
> Subject: [v3 i-g-t 00/14] Fix mode selection for 2x tests
> 
> When two monitors connected through MST, the second monitor also
> tries to use the same mode. So two such modes may not fit into the
> link bandwidth.
> 
> This series will find a combination of modes that fit into the BW.
> 
> IGT core helper would override the mode on all connectors that will
> be modeset by the next igt_display_commit() call in the test. These
> are all the connectors in igt_display_t that have a pending_pipe set
> by the test up to the point of calling this helper.
> 
> For 1x tests, cleanup the state before exiting the test.
> 
> Follow-up:
> As modeset will happen one by one, we can't apply this approach on
> tests/kms_flip.c & tests/kms_setmode.c
> 
> 
> Cc: Imre Deak <imre.deak at intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> 
> Bhanuprakash Modem (14):
>   lib/igt_kms: helper to override the mode on all connectors
>   tests/kms_frontbuffer_tracking: Fix mode selection for 2x tests
>   tests/kms_cursor_legacy: Fix mode selection for 2x tests
>   tests/debugfs_test: Fix mode selection for MST
>   tests/kms_content_protection: Fix mode selection for 2x tests
>   tests/kms_plane_scaling: Fix mode selection for 2x tests
>   tests/kms_atomic_transition: Fix mode selection for 2x tests
>   tests/kms_plane: Reset the state before exiting the test
>   tests/kms_plane_alpha_blend: Reset the state before exiting the test
>   tests/kms_cursor_edge_walk: Reset the state before exiting the test
>   tests/kms_plane_lowres: Reset the state before exiting the test
>   tests/kms_plane_cursor: Reset the state before exiting the test
>   tests/kms_flip_scaled_crc: Reset the state before exiting the test
>   tests/kms_vblank: Reset the state before exiting the test
> 
>  lib/igt_kms.c                    | 55 ++++++++++++++++++++++++++++++++
>  lib/igt_kms.h                    |  1 +
>  tests/debugfs_test.c             | 10 ++++++
>  tests/kms_atomic_transition.c    | 10 ++++++
>  tests/kms_content_protection.c   | 41 ++++++++++--------------
>  tests/kms_cursor_edge_walk.c     |  3 ++
>  tests/kms_cursor_legacy.c        | 47 +++++++++++++++++++++++++--
>  tests/kms_flip_scaled_crc.c      |  5 +++
>  tests/kms_frontbuffer_tracking.c | 33 +++++++++++++++++++
>  tests/kms_plane.c                | 19 +++++++----
>  tests/kms_plane_alpha_blend.c    |  5 +--
>  tests/kms_plane_cursor.c         |  4 +++
>  tests/kms_plane_lowres.c         |  9 ++----
>  tests/kms_plane_scaling.c        | 15 +++++++--
>  tests/kms_vblank.c               |  2 ++
>  15 files changed, 214 insertions(+), 45 deletions(-)

@Imre/@Daniel, if possible can you please review this series?

> 
> --
> 2.20.1



More information about the igt-dev mailing list