[igt-dev] [PATCH i-g-t v3 01/52] lib/igt_dummyload: Add support of using allocator in igt spinner

Dixit, Ashutosh ashutosh.dixit at intel.com
Tue Aug 3 23:07:07 UTC 2021


On Mon, 26 Jul 2021 12:59:35 -0700, Zbigniew Kempczyński wrote:
>
> @@ -164,16 +171,34 @@ emit_recursive_batch(igt_spin_t *spin,
>	execbuf->buffer_count++;
>	cs = spin->batch;
>
> -	obj[BATCH].offset = addr;
> +	if (ahnd)
> +		addr = intel_allocator_alloc_with_strategy(ahnd, obj[BATCH].handle,
> +							   BATCH_SIZE, 0,
> +							   ALLOC_STRATEGY_LOW_TO_HIGH);

Is the strategy argument just for debug, so that spin offsets look
different from offsets for other objects? Since everyone should be
allocating from the same allocator which is managing offsets this should
probably not be needed?

In any case, the patch is great, so this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>


More information about the igt-dev mailing list