[igt-dev] [PATCH i-g-t v3 16/52] tests/gem_ctx_param: Adopt to use allocator

[Zbigniew Kempczyński]

On Thu, Aug 05, 2021 at 12:18:18AM -0700, Dixit, Ashutosh wrote:
> On Mon, 26 Jul 2021 12:59:50 -0700, Zbigniew Kempczyński wrote:
> >
> > diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c
> > index c795f1b45..11bc08e36 100644
> > --- a/tests/i915/gem_ctx_param.c
> > +++ b/tests/i915/gem_ctx_param.c
> > @@ -165,6 +165,7 @@ static void test_vm(int i915)
> >	int err;
> >	uint32_t parent, child;
> >	igt_spin_t *spin;
> > +	uint64_t ahnd;
> >
> >	/*
> >	 * Proving 2 contexts share the same GTT is quite tricky as we have no
> > @@ -190,7 +191,8 @@ static void test_vm(int i915)
> >
> >	/* Test that we can't set the VM after we've done an execbuf */
> >	arg.ctx_id = gem_context_create(i915);
> > -	spin = igt_spin_new(i915, .ctx_id = arg.ctx_id);
> > +	ahnd = get_reloc_ahnd(i915, arg.ctx_id);
> > +	spin = igt_spin_new(i915, .ahnd = ahnd, .ctx_id = arg.ctx_id);
> >	igt_spin_free(i915, spin);
> >	arg.value = gem_vm_create(i915);
> >	err = __gem_context_set_param(i915, &arg);
> > @@ -202,7 +204,7 @@ static void test_vm(int i915)
> >	child = gem_context_create(i915);
> >
> >	/* Create a background spinner to keep the engines busy */
> > -	spin = igt_spin_new(i915);
> > +	spin = igt_spin_new(i915, .ahnd = ahnd);
> >	for (int i = 0; i < 16; i++) {
> >		spin->execbuf.rsvd1 = gem_context_create(i915);
> >		__gem_context_set_priority(i915, spin->execbuf.rsvd1, 1023);
> > @@ -259,6 +261,7 @@ static void test_vm(int i915)
> >	igt_spin_free(i915, spin);
> >	gem_sync(i915, batch.handle);
> >	gem_close(i915, batch.handle);
> > +	put_ahnd(ahnd);
> 
> I think this should work even thought the context against which ahnd has
> been created has been destroyed after the first spin_free, but please
> check:
> 
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>

Yes, ahnd is only offset provider here for spinners. But to avoid 
confusion I'm going to delete first ahnd (for arg.ctx_id and recreate
ahnd for default context before start second spinner.

As this is cosmetic change I dare to keep your r-b.

--
Zbigniew