[igt-dev] [PATCH i-g-t v4 18/56] tests/gem_exec_balancer: Adopt to use allocator

[Zbigniew Kempczyński]

On Fri, Aug 06, 2021 at 02:48:19PM -0700, Dixit, Ashutosh wrote:
> On Fri, 06 Aug 2021 06:41:07 -0700, Zbigniew Kempczyński wrote:
> >
> > For newer gens we're not able to rely on relocations. Adopt to use
> > offsets acquired from the allocator.
> 
> One minor fix below, with that:
> 
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
> 
> > @@ -1334,11 +1347,13 @@ static void __bonded_nohang(int i915, const intel_ctx_t *ctx,
> >	};
> >	igt_spin_t *time, *spin;
> >	const intel_ctx_t *load;
> > +	uint64_t ahnd0 = get_reloc_ahnd(i915, 0), ahnd;
> >
> >	load = ctx_create_balanced(i915, siblings, count);
> >	gem_context_set_priority(i915, load->id, 1023);
> > +	ahnd = get_reloc_ahnd(i915, ctx->id);
> 
> ahnd = get_reloc_ahnd(i915, load->id);

Good catch, thanks for finding this. From the offset perspective it 
shouldn't matter but for consistency it is. 

--
Zbigniew

> 
> >
> > -	spin = igt_spin_new(i915, .ctx = load, .engine = 1);
> > +	spin = igt_spin_new(i915, .ahnd = ahnd, .ctx = load, .engine = 1);