[igt-dev] [PATCH i-g-t v4 29/56] tests/gem_mmap: Add allocator support

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Mon Aug 9 08:59:57 UTC 2021


On Fri, Aug 06, 2021 at 03:41:18PM +0200, Zbigniew Kempczyński wrote:
> From: Ch Sai Gowtham <sai.gowtham.ch at intel.com>
> 
> When relocations are not available tests must assign addresses to objects
> by themselves instead of relying on the driver. We use allocator for
> that purpose.
> 
> Signed-off-by: Ch Sai Gowtham <sai.gowtham.ch at intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Petri Latvala <petri.latvala at intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit at intel.com>
> ---
>  tests/i915/gem_mmap.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_mmap.c b/tests/i915/gem_mmap.c
> index a77c0ad60..61c9c5c19 100644
> --- a/tests/i915/gem_mmap.c
> +++ b/tests/i915/gem_mmap.c
> @@ -123,8 +123,9 @@ test_pf_nonblock(int i915)
>  {
>  	igt_spin_t *spin;
>  	uint32_t *ptr;
> +	uint64_t ahnd = get_reloc_ahnd(i915, 0);
>  
> -	spin = igt_spin_new(i915);
> +	spin = igt_spin_new(i915, .ahnd = ahnd);
>  
>  	igt_set_timeout(1, "initial pagefaulting did not complete within 1s");
>  
> @@ -135,6 +136,7 @@ test_pf_nonblock(int i915)
>  	igt_reset_timeout();
>  
>  	igt_spin_free(i915, spin);
> +	put_ahnd(ahnd);
>  }
>  
>  static int mmap_ioctl(int i915, struct drm_i915_gem_mmap *arg)
> -- 
> 2.26.0
> 

LGTM

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew


More information about the igt-dev mailing list