[igt-dev] [PATCH i-g-t v4 22/56] tests/gem_exec_gttfill: Require relocation support

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Mon Aug 9 12:38:02 UTC 2021


On Fri, Aug 06, 2021 at 03:41:11PM +0200, Zbigniew Kempczyński wrote:
> From: Andrzej Turko <andrzej.turko at linux.intel.com>
> 
> Since this test uses relocations, which are now disabled on newer
> generations, we need to skip the test if they are not supported.
> In order to maintain coverage a slightly modified version of this test
> using softpinning instead of relocations is added to gem_softpin.
> 
> Signed-off-by: Andrzej Turko <andrzej.turko at linux.intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> ---
>  tests/i915/gem_exec_gttfill.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/i915/gem_exec_gttfill.c b/tests/i915/gem_exec_gttfill.c
> index b8283eb8f..f16428714 100644
> --- a/tests/i915/gem_exec_gttfill.c
> +++ b/tests/i915/gem_exec_gttfill.c
> @@ -216,6 +216,7 @@ igt_main
>  	igt_fixture {
>  		i915 = drm_open_driver(DRIVER_INTEL);
>  		igt_require_gem(i915);
> +		igt_require(gem_has_relocations(i915));
>  		ctx = intel_ctx_create_all_physical(i915);
>  		igt_fork_hang_detector(i915);
>  	}
> -- 
> 2.26.0
> 

Regardless status of adding softpin version of this test this patch
looks ok:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
--
Zbigniew


More information about the igt-dev mailing list