[igt-dev] [PATCH i-g-t 4/5] tests/gem_exec_schedule: Adopt to use allocator

Dixit, Ashutosh ashutosh.dixit at intel.com
Tue Aug 17 04:11:29 UTC 2021


On Mon, 16 Aug 2021 19:20:01 -0700, Dixit, Ashutosh wrote:
>
> > +		for (i = 0; i < GEM_MAX_ENGINES; i++)
> > +			if (sema[i])
> > +				igt_spin_free(i915, sema[i]);
>
> Did we create this array etc. to avoid the stall when the spin is freed and
> the offset is reused? Or is there a different reason?

A one line comment about why this was done would be nice prior to merging.

>
> Otherwise this is:
>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>


More information about the igt-dev mailing list