[igt-dev] [PATCH 4/4] test/kms_atomic: Skip plane overlay test for amdgpu

[Petri Latvala]

On Wed, Aug 18, 2021 at 10:56:14AM -0400, Rodrigo Siqueira wrote:
> Currently, amdgpu does not support an overlay strategy. As a result,
> plane_overlay fails on amdgpu; since this is a driver limitation, this
> commit skips the overlay test for amdgpu.
> 
> Cc: Harry Wentland <harry.wentland at amd.com>
> Cc: Nicholas Choi <Nicholas.Choi at amd.com>
> Cc: Sean Paul <seanpaul at chromium.org>
> Cc: Mark Yacoub <markyacoub at chromium.org>
> Cc: Melissa Wen <melissa.srw at gmail.com>
> Cc: Arkadiusz Hiler <arek at hiler.eu>
> Cc: Petri Latvala <petri.latvala at intel.com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> ---
>  tests/kms_atomic.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> index 1e1bee4d..e460ba35 100644
> --- a/tests/kms_atomic.c
> +++ b/tests/kms_atomic.c
> @@ -501,6 +501,13 @@ static void plane_overlay(igt_pipe_t *pipe, igt_output_t *output, igt_plane_t *p
>  	uint32_t w = mode->hdisplay / 2;
>  	uint32_t h = mode->vdisplay / 2;
>  
> +	/* On AMD, with hardware cursor, overlay plane must fully cover
> +	 * the primary plane (underlay). AMD does not support this test
> +	 * scenario
> +	 */
> +	if (is_amdgpu_device(output->display->drm_fd))
> +		igt_require(0);
> +

A skip result with a message of "requirement not met: 0" requires
special magic to understand without reading the code.

How about

igt_require_f(!is_amdgpu_device(output->display->drm_fd),
              "Overlay must fully cover the primary plane on AMD\n");



-- 
Petri Latvala